Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gcp_organization_project table #663

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Oct 1, 2024

This PR adds a gcp_organization_project table that is identical to the gcp_project, except that it does not filter on the project attached to the connection.

This allows to discover all projects accessible with some credentials.

Slack thread: https://turbot-community.slack.com/archives/C044P668806/p1727786122009859

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
Add example SQL query results here (please include the input queries as well)

@pdecat pdecat changed the title feat: add gcp_organization_project table feat: add gcp_organization_project table Oct 1, 2024
@pdecat pdecat marked this pull request as draft October 1, 2024 14:31
@misraved misraved requested a review from ParthaI October 1, 2024 18:17
@misraved misraved added the hacktoberfest-accepted This pull request has been accepted for Hacktoberfest label Oct 1, 2024
@pdecat pdecat force-pushed the feat/gcp_org_project branch 3 times, most recently from 78200ad to 23dc86f Compare October 5, 2024 09:08
@pdecat pdecat force-pushed the feat/gcp_org_project branch from 49ff495 to 700c183 Compare October 7, 2024 15:31
Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pdecat for adding the new table 👍!!

Left a minor suggestion 😄.

Makefile Outdated
install:
go build -o $(STEAMPIPE_INSTALL_DIR)/plugins/hub.steampipe.io/plugins/turbot/gcp@latest/steampipe-plugin-gcp.plugin -tags "${BUILD_TAGS}" *.go
go build -o $(STEAMPIPE_INSTALL_DIR)/plugins/hub.steampipe.io/plugins/turbot/gcp@$(STEAMPIPE_PLUGIN_VERSION)/steampipe-plugin-gcp.plugin -tags "${BUILD_TAGS}" *.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use this locally to install custom builds to specific versions of the plugin, but can remove it.

@pdecat pdecat force-pushed the feat/gcp_org_project branch from 700c183 to 1b2f13a Compare November 21, 2024 12:33
@misraved misraved merged commit 7b922ac into turbot:main Nov 25, 2024
1 check passed
@pdecat pdecat deleted the feat/gcp_org_project branch November 25, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted This pull request has been accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants