-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize the gcp_logging_log_entry table result or result timing by applying a timestamp filter and added the columns json_payload, proto_payload, metadata, resource, operation and tags Closes #507 #508
Conversation
…pplying a timestamp filter Closes #507
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other suggestions:
- Remove "log_entry_" prefix from columns.
- Consolidate JSON columns so each property has only 1 column, we can always add more columns later on. This will be a breaking change but I think will make the table columns more consistent and easy to maintain in the future.
gcp/table_gcp_logging_log_entry.go
Outdated
// Default limit is set as 1000 | ||
pageSize := types.Int64(1000) | ||
// Default limit is set as 10000 | ||
// After conducting tests with maximum page sizes of 1000, 5000, 17000, 20000, and 30000, we decided to stick with a page size of 10000 for performance improvement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// After conducting tests with maximum page sizes of 1000, 5000, 17000, 20000, and 30000, we decided to stick with a page size of 10000 for performance improvement. | |
// 10000 seems to be a balanced limit, based on initial tests for retrieving 140k log entries: 5000 (124s), 10000 (88s), 20000 (84s) |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParthaI Please see comments, thanks!
Integration test logs
Logs
Example query results
Results