Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tags to aws_backup_plan table #2336

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Nov 7, 2024

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
> SELECT
  name,
  region,
  tags
FROM aws_backup_plan
WHERE
  name LIKE '%pdecat%'

+-----------------------+-----------+-------------------+
| name                  | region    | tags              |
+-----------------------+-----------+-------------------+
| test-pdecat-plan-tags | eu-west-3 | {"test":"pdecat"} |
+-----------------------+-----------+-------------------+

@pdecat pdecat changed the title feat: add tags to aws_backup_plan table feat: add tags to aws_backup_plan table Nov 7, 2024
var ae smithy.APIError
if errors.As(err, &ae) {
if ae.ErrorCode() == "ResourceNotFoundException" {
return &backup.GetBackupVaultNotificationsOutput{}, nil
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type was incorrect, copied/pasted from above function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant