Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed aws_servicequotas_service_quota queries fail when querying multiple regions with the same service_code Closes #2313 #2314

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fixed aws_servicequotas_service_quota queries fail when querying multiple regions with the same service_code Closes #2313 #2314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion aws/table_aws_servicequotas_service_quota.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ func tableAwsServiceQuotasServiceQuota(_ context.Context) *plugin.Table {
ShouldIgnoreErrorFunc: shouldIgnoreErrors([]string{"NoSuchResourceException"}),
},
Get: &plugin.GetConfig{
KeyColumns: plugin.AllColumns([]string{"service_code", "quota_code"}),
// By design, the Get config is expected to return a single row, regardless of regions.
// To prevent the error "get call returned 23 results - the key column is not globally unique," we have included the "region" in the key columns.
Hydrate: getServiceQuota,
KeyColumns: plugin.AllColumns([]string{"service_code", "quota_code", "region"}),
Tags: map[string]string{"service": "servicequotas", "action": "GetServiceQuota"},
IgnoreConfig: &plugin.IgnoreConfig{
ShouldIgnoreErrorFunc: shouldIgnoreErrors([]string{"NoSuchResourceException"}),
Expand Down
Loading