Compatibility with MySQL (MariaDB) storage #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoehermann
commented
Feb 4, 2022
Comment on lines
-180
to
+184
| VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14) | ||
| ON CONFLICT (jid) DO UPDATE SET platform=$12, business_name=$13, push_name=$14 | ||
| VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) | ||
| ON CONFLICT (jid) DO UPDATE SET platform=?, business_name=?, push_name=? |
There was a problem hiding this comment.
Apparently, MySQL (MariaDB) does not do positional placeholders. We must use some repetition. :(
hoehermann
commented
Feb 4, 2022
| @@ -243,3 +247,17 @@ func (c *Container) DeleteDevice(store *store.Device) error { | |||
| _, err := c.db.Exec(deleteDeviceQuery, store.ID.String()) | |||
| return err | |||
| } | |||
|
|
|||
| var ( | |||
| mysqlConflictPattern = regexp.MustCompile(`ON CONFLICT \([^)]+\) DO UPDATE SET`) // cannot be const | |||
There was a problem hiding this comment.
ON CONFLICT is the only statement which is not supported by MariaDB. Everything else is just fine.
hoehermann
changed the title
hoehermann
commented
Feb 4, 2022
Comment on lines
-150
to
+151
| insertPreKeyQuery = `INSERT INTO whatsmeow_pre_keys (jid, key_id, key, uploaded) VALUES ($1, $2, $3, $4)` | ||
| getUnuploadedPreKeysQuery = `SELECT key_id, key FROM whatsmeow_pre_keys WHERE jid=$1 AND uploaded=false ORDER BY key_id LIMIT $2` | ||
| getPreKeyQuery = `SELECT key_id, key FROM whatsmeow_pre_keys WHERE jid=$1 AND key_id=$2` | ||
| deletePreKeyQuery = `DELETE FROM whatsmeow_pre_keys WHERE jid=$1 AND key_id=$2` | ||
| markPreKeysAsUploadedQuery = `UPDATE whatsmeow_pre_keys SET uploaded=true WHERE jid=$1 AND key_id<=$2` | ||
| getUploadedPreKeyCountQuery = `SELECT COUNT(*) FROM whatsmeow_pre_keys WHERE jid=$1 AND uploaded=true` | ||
| getLastPreKeyIDQuery = `SELECT MAX(key_id) FROM whatsmeow_pre_keys WHERE jid=?` | ||
| insertPreKeyQuery = "INSERT INTO whatsmeow_pre_keys (jid, key_id, `key`, uploaded) VALUES (?, ?, ?, ?)" | ||
| getUnuploadedPreKeysQuery = "SELECT key_id, `key` FROM whatsmeow_pre_keys WHERE jid=? AND uploaded=false ORDER BY key_id LIMIT ?" | ||
| getPreKeyQuery = "SELECT key_id, `key` FROM whatsmeow_pre_keys WHERE jid=? AND key_id=?" |
There was a problem hiding this comment.
In MySQL, key is a keyword. We must escape it with backticks. It seems that in go, you cannot have backticks in raw strings. Maybe we should use non-raw strings everywhere just for consistency?
hoehermann
commented
Feb 4, 2022
Comment on lines
+345
to
+350
| func (s *SQLStore) putAppStateMutationMACs(tx execable, name string, version uint64, mutations []store.AppStateMutationMAC) (err error) { | ||
| for _, mutation := range mutations { | ||
| query := putAppStateMutationMACsQuery + "(?, ?, ?, ?, ?)" | ||
| _, err = tx.Exec(query, s.JID, name, version, mutation.IndexMAC, mutation.ValueMAC) | ||
| if err != nil { | ||
| return |
There was a problem hiding this comment.
This will impact performance, but it simplifies the query.
leandro-uex
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
My project purple-whatsmeow gained some traction based on your awesome work. I am getting requests to support MySQL for the storage. I looked into it. The necessary changes do not seem too drastic. However, all experienced and mentally sane people I talked to urged me to use a DBMS. "Adjustments with regexes would be insane", they said. But here we are anyway.
I tested my changes against SQLite and MySQL, but not with PostgreSQL. I would consider these changes experimental. Table creation and upgrades would have to be done manually, but for now "it is working for me"™.
What do you think?
Kind regards
Hermann