Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #25 dependencies and feat: #10 redirect to current song #28

Closed
wants to merge 5 commits into from

Conversation

42Willow
Copy link

@42Willow 42Willow commented May 12, 2024

PR #16 works fine locally but doesn't work on Vercel.

Adding this:
vercel.json

{
    "routes": [{
        "src": "/api/(.*)",
        "dest": "api/index.py"
    }]
}

fixed the issue

Working deployment: https://spotify-readme-8i1rak5nw-42willows.vercel.app/api


I'm not sure if I should lock the dependencies, it's probably good practice to

Copy link

vercel bot commented May 12, 2024

@42Willow is attempting to deploy a commit to the tthn0's projects Team on Vercel.

A member of the Team first needs to authorize it.

@42Willow 42Willow changed the title fix: #25 and feat: #10 redirect to current song fix: #25 dependencies and feat: #10 redirect to current song May 12, 2024
@42Willow
Copy link
Author

@dedomil

@dedomil
Copy link

dedomil commented May 12, 2024

This looks better, will close my pull request as this one works as expected!

@dedomil dedomil mentioned this pull request May 12, 2024
@tthn0
Copy link
Owner

tthn0 commented Jul 21, 2024

The outdated dependencies and #10 will be addressed in the next commit.

@tthn0 tthn0 closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants