Drop Router V1 #2621
Merged
Drop Router V1 #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpjunior
force-pushed
the
drop-router-v1
branch
from
6cf0bd5
to
0556d4f
Compare
wpjunior
force-pushed
the
drop-router-v1
branch
from
0556d4f
to
e01b490
Compare
wpjunior
commented
Dec 21, 2023
| @@ -842,10 +846,13 @@ func (app *App) AddUnits(n uint, process, versionStr string, w io.Writer) error | |||
| &reserveUnitsToAdd, | |||
| &provisionAddUnits, | |||
| ).Execute(app.ctx, app, n, w, process, version) | |||
| rebuild.RoutesRebuildOrEnqueueWithProgress(app.Name, w) | |||
There was a problem hiding this comment.
Maybe we can remove this call
wpjunior
force-pushed
the
drop-router-v1
branch
8 times, most recently
from
66e5ec8
to
112284a
Compare
wpjunior
force-pushed
the
drop-router-v1
branch
2 times, most recently
from
2a9359f
to
6033461
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.