Skip to content

fix: run traces from the workspace cwd on Windows#52

Open
yichensunjoe wants to merge 1 commit intotsperf:mainfrom
yichensunjoe:codex/fix-trace-command-windows
Open

fix: run traces from the workspace cwd on Windows#52
yichensunjoe wants to merge 1 commit intotsperf:mainfrom
yichensunjoe:codex/fix-trace-command-windows

Conversation

@yichensunjoe
Copy link
Copy Markdown

Fixes #48.

Summary

  • stop wrapping the trace command in an inline (cd ...) shell snippet
  • run the configured trace command from the selected workspace/project cwd instead
  • quote the generated trace directory with shell-aware rules so cmd.exe and POSIX shells both work
  • add unit coverage for Windows default-shell, bash-on-Windows, POSIX escaping, and shell fallback behavior

Validation

  • pnpm exec eslint src/commands.ts src/shell.ts test/index.test.ts
  • pnpm exec vitest run test/index.test.ts
  • pnpm typecheck
  • pnpm build

@yichensunjoe yichensunjoe requested a review from danielroe as a code owner April 16, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trace doesn't work if project isn't on C:/ drive

1 participant