Prevent iterating over a TopologyCounter

[benjeffery]

Fixes #1462

[benjeffery]

@hyanwong You're closer to this than I am - this seems like it should fix #1462. yes?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (e81ee40) to head (ddb4787).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3202   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files          28       28           
  Lines       31978    31980    +2     
  Branches     5872     5872           
=======================================
+ Hits        28662    28664    +2     
  Misses       1886     1886           
  Partials     1430     1430           

Flag	Coverage Δ
c-tests	86.66% <ø> (ø)
lwt-tests	80.38% <ø> (ø)
python-c-tests	88.18% <ø> (ø)
python-tests	98.86% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
python/tskit/combinatorics.py	99.36% <100.00%> (+<0.01%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[hyanwong]

I'm not sure. I think @daniel-goldstein suggested actually implementing the iterator in #1462 (comment) rather than making it bomb out.

It should be easy, it's just choosing either 1 or 2 from his list. Do you have a preference @benjeffery ?

[benjeffery]

Is what I've done here correct in that iterating .topologies makes sense?

[jeromekelleher]

Let's take the simple path here and raise an error rather than try to implement the right thing

[benjeffery]

Let's take the simple path here and raise an error rather than try to implement the right thing

Yes, my focus was on preventing the easy to trigger infinite loop.