Skip to content

Conversation

@petrelharp
Copy link
Contributor

The downside here is that the resulting tree sequence can't be loaded back into SLiM. We could go and put the 'sample' flags back after recapitation, but it just seems weird to have them there anyhow. All this will be changing with the new model.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes missing coverage. Please review.

Project coverage is 94.01%. Comparing base (46809d4) to head (658f9fd).

Files with missing lines Patch % Lines
pyslim/methods.py 21.42% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
- Coverage   95.65%   94.01%   -1.64%     
==========================================
  Files           8        8              
  Lines         621      635      +14     
  Branches      131      136       +5     
==========================================
+ Hits          594      597       +3     
- Misses         18       27       +9     
- Partials        9       11       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petrelharp
Copy link
Contributor Author

Superceded by #367.

@petrelharp petrelharp closed this Jul 31, 2025
@petrelharp petrelharp deleted the null_recap branch August 1, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants