Issue #373

[minhnguyenxuan60]

Summary

Add a new field (city) into Dataframe so that we can tell which city the current dataset is inside MapViz. Change index.tsx and socrataResultsToDataframe.ts files accordingly so that we can get the city abbreviation. Add a json file to store location of each city (for now, it only has Chicago and New York).

Screenshots or Videos (if applicable)

Example of what it looks like when click on map under visualize tab for a dataset in Chicago.

Example of what it looks like whne click on map under visualize tab for a dataset in New York.

Related Issues

N/A

Test Plan

1. Go to Explore
2. Choose a city (Chicago or New York)
3. Click on any dataset
4. Click on Visualize tab
5. Change to map
6. It should zoom in whichever city of the dataset that you choose on step 2 (only works for Chicago and New York for now)

Checklist Before Requesting a Review

• I have performed a self-review of my code
• My code follows the Style Guidelines and Best Practices outlined in the project wiki
• I have commented my code, particularly in hard-to-understand areas
• I have made changes to the documentation, if applicable
• My change generates no new warnings or failed tests
• If it is a core feature, I have added thorough tests
• I have implemented analytics, if applicable

[jps327]

This is fantastic, thank you! I've tested it and it works for Chicago.

Could you please address the comments I've left? In summary there are two things to change:

1. Let's hard code the coordinates in portal_configs.json so that we keep all hardcoded values to a single file.
2. Let's set a default coordinate of [0, 0] and zoom the map out when a hardcoded coordinate could not be found.

[jps327]

If city does not exist in coordinate this returns undefined which causes Mapbox to error. We should still have a default value for that case. A common solution would be to default to [0, 0] and change the zoom value to zoom out and show the whole map - this is the most common approach to showing an 'empty' map.

[jps327]

This is great - would it be possible to include these in src/portal_configs.json instead and read the values from there? That way we don't have two different files of constants for each city.

[minhnguyenxuan60]

Hi Juan, thank you for reviewing my pull request. I have changed my code as you requested. Please tell me if there is anything else that I need to change.

[jps327]

Thank you, this is great! This will be in the next release