Updated Sendgrid Analyzer #3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abmussani
reviewed
Feb 14, 2025
|
|
||
| return &profile, nil | ||
| } | ||
|
|
||
| func secretInfoToAnalyzerResult(info *SecretInfo) *analyzers.AnalyzerResult { |
There was a problem hiding this comment.
@kashifkhan0771 Profile is being fetch based on a scope. My suggestion would to include it in Analyzer Result associated to that particular permission.
kashifkhan0771
force-pushed
the
update/oss-115-sendgrid-analyzer
branch
from
1dff64d to
3cc348a
Compare
zricethezav
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is related to #3872
Checklist:
make test-community)?make lintthis requires golangci-lint)?