Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sendgrid Analyzer Update - Add Key Ownership Details #3872

Closed
joeleonjr opened this issue Feb 5, 2025 · 1 comment · Fixed by #3906
Closed

Sendgrid Analyzer Update - Add Key Ownership Details #3872

joeleonjr opened this issue Feb 5, 2025 · 1 comment · Fixed by #3906
Assignees
@kashifkhan0771
Labels
enhancement

Comments

@joeleonjr
Copy link
Contributor

Description

Currently, the Sendgrid Analyzer does not provide users with key ownership information.

Preferred Solution

For API keys that have proper permissions to access this endpoint, we can add username, email address, phone number and more to the output.
@kashifkhan0771
Copy link
Contributor

We can include the username in the output. Other fields like phone number and address are considered personally identifiable information (PII). While I don't recall the exact discussion, @abmussani, @mcastorina, and I agreed not to include such information in the output.

@kashifkhan0771 kashifkhan0771 mentioned this issue Feb 12, 2025
Merged
2 tasks
@kashifkhan0771 kashifkhan0771 linked a pull request Feb 12, 2025 that will close this issue
Updated Sendgrid Analyzer #3906
Merged
2 tasks
@kashifkhan0771 kashifkhan0771 self-assigned this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kashifkhan0771 kashifkhan0771

Labels
enhancement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated Sendgrid Analyzer kashifkhan0771/trufflehog
2 participants
@joeleonjr @kashifkhan0771