Added support for weaviate vector database #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S1LV3RJ1NX
requested changes
Oct 7, 2024
backend/vectordb.requirements.txt
Outdated
| @@ -2,4 +2,4 @@ | |||
| singlestoredb==1.0.4 | |||
|
|
|||
| ### Weaviate client (in progress) | |||
There was a problem hiding this comment.
Can remove this in progress comment.
| # TODO (chiragjn): Revisit this, we should not be letting `value` be empty | ||
| document_ids.add(group.get("groupedBy", {}).get("value", "") or "") | ||
| return list(document_ids) | ||
| pass |
There was a problem hiding this comment.
This function can be removed as it is not in the base class.
| # TODO (chiragjn): Revisit this, we should not be letting `value` be empty | ||
| document_ids.add(group.get("groupedBy", {}).get("value", "") or "") | ||
| return list(document_ids) | ||
| pass | ||
|
|
||
| def delete_documents(self, collection_name: str, document_ids: List[str]): |
There was a problem hiding this comment.
This function can be removed as it is not in the base class.
Co-authored-by: Prathamesh Saraf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested the changes locally using weaviate cloud instance.
Initial Insertion(Added two files, file1 and file2):
Incremental Insertion(Added two more file, file3 and file4):
Weaviate dashboard(4 objects inserted to the collection):
