feat(treafik): bump to v3 #21665
Draft
feat(treafik): bump to v3 #21665
+4
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stavros-k
commented
May 6, 2024
| @@ -26,8 +26,6 @@ spec: | |||
| server: "" | |||
| forceSTSHeader: true | |||
| referrerPolicy: same-origin | |||
| sslForceHost: true | |||
| sslRedirect: true | |||
There was a problem hiding this comment.
stavros-k
commented
May 6, 2024
| @@ -26,8 +26,6 @@ spec: | |||
| server: "" | |||
| forceSTSHeader: true | |||
| referrerPolicy: same-origin | |||
| sslForceHost: true | |||
There was a problem hiding this comment.
stavros-k
commented
May 6, 2024
| @@ -7,7 +7,7 @@ metadata: | |||
| name: {{ ternary (printf "%v-%v" $.Release.Name $middlewareData.name) $middlewareData.name $.Values.ingressClass.enabled }} | |||
| namespace: {{ $.Release.Namespace }} | |||
| spec: | |||
| ipWhiteList: | |||
There was a problem hiding this comment.
|
Note: It most likely also need to update CRDs! |
📝 Linting results:✔️ Linting [charts/premium/traefik]: Passed - Took 1 seconds ✅ Linting: Passed - Took 1 seconds |
We're moving Traefik CRDs to a seperate helm-chart, this might be a good moment to start enforcing that tbh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
⚒️ Fixes #
⚙️ Type of change
🧪 How Has This Been Tested?
📃 Notes:
✔️ Checklist:
feat(chart-name):,fix(chart-name):orchore(chart-name):➕ App addition
If this PR is an app addition please make sure you have done the following.
icon.pngPlease don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.