Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docuseal): Add Docuseal #21453

Merged

Conversation

SolidSly
Copy link
Contributor

@SolidSly SolidSly commented May 1, 2024

Description

⚒️ Fixes #

It solves #21452.

It is possible to use an external psql database. However, I think it is a little over complicated for no real need beside if you are a company with many users. At the moment, this Helm chart supports sqlite by default.
It is possible to use an external database by adding a custom environment variable (cf link).

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

Tested locally using Helm commands, on a TrueNAS system.

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning
  • I made sure the title starts with feat(chart-name):, fix(chart-name): or chore(chart-name):

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

There is no icon.png in Chart folder, but webp images. I added them for this Helm chart.


Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@SolidSly SolidSly requested review from Ornias1993 and a team as code owners May 1, 2024 11:19
@SolidSly SolidSly marked this pull request as draft May 1, 2024 11:26
@SolidSly
Copy link
Contributor Author

SolidSly commented May 1, 2024

This PR will be closed as it is not possible to add new Helm chart currently (cf link).

@SolidSly SolidSly closed this May 1, 2024
@stavros-k
Copy link
Member

Please see #21452 (comment)

@SolidSly SolidSly reopened this May 1, 2024
@SolidSly SolidSly marked this pull request as ready for review May 1, 2024 13:45
Copy link
Member

@stavros-k stavros-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SolidSly SolidSly requested a review from stavros-k May 12, 2024 08:35
@SolidSly
Copy link
Contributor Author

It should be working fine now. CNPG has been included too.

@SolidSly SolidSly requested review from alfi0812, bakayukii and a team as code owners May 19, 2024 11:37
@StevenMcElligott StevenMcElligott dismissed stavros-k’s stale review May 19, 2024 12:43

Added CNPG and reviewed

@StevenMcElligott StevenMcElligott changed the title feat(docuseal) Introduce new Helm chart feat(docuseal): Add Docuseal May 19, 2024
@StevenMcElligott StevenMcElligott merged commit 92d3d0e into truecharts:master May 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants