-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload existing world guide Documentation #19776
Conversation
As I had some difficulty with uploading my existing world files to the app, after getting some help. I thought best to write down the instruction for others to follow. Signed-off-by: LordCrash101 <[email protected]>
Signed-off-by: LordCrash101 <[email protected]>
Signed-off-by: LordCrash101 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the docs name needs to be changed from spaces to -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add new lines
Co-authored-by: Xstar97TheNoob <[email protected]> Signed-off-by: bitpushr <[email protected]>
Co-authored-by: Xstar97TheNoob <[email protected]> Signed-off-by: bitpushr <[email protected]>
sorry slightly confused, did you need me to rename the file to replace spaces with dashes? I'm fairly new to using the git, so sorry for silly comments! |
All good. You can see the updates/changes that were made by Xstar in the commits above your comment. We're having some CI/automation issues with docs atm so these changes might not show up for a while, but should eventually flow through to the website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
THis seems to be SCALE only, we don't want SCALE-only guides unless strictly labeled as such
-
The whole windows part is so user specific, doesn't seem like a TrueCharts thing to add either
> * THis seems to be SCALE only, we don't want SCALE-only guides unless strictly labeled as such > * The whole windows part is so user specific, doesn't seem like a TrueCharts thing to add either Unfortunately I found next to no guides for this SCALE app as it is, I felt having something that might point others in the general direction was better than having nothing at all. |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Username Password | c1c8968 | charts/incubator/slskd/values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Signed-off-by: bitpushr <[email protected]>
As SCALE Apps are deprecated now, i'm (in the end) not going to merge this. |
@all-contributors please add @LordCrash101 for docs |
I've put up a pull request to add @LordCrash101! 🎉 |
Adds @LordCrash101 as a contributor for doc. This was requested by Ornias1993 [in this comment](#19776 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
As I had some difficulty with uploading my existing world files to the app, after getting some help. I thought best to write down the instructions for others to follow.
Description
⚒️ Fixes # Added documentation
⚙️ Type of change
🧪 How Has This Been Tested?
📃 Notes:
As this is only a documentation addition, I'm not sure I have more testing to add other than what I wrote are the steps I followed to get it working.
✔️ Checklist:
feat(chart-name):
,fix(chart-name):
orchore(chart-name):
➕ App addition
If this PR is an app addition please make sure you have done the following.
icon.png
Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.