Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(whishper ): add whishper chart #19147

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

feat(whishper ): add whishper chart #19147

wants to merge 28 commits into from

Conversation

Ornias1993
Copy link
Member

Description

⚒️ Fixes #16708

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@xstar97
Copy link
Contributor

xstar97 commented Mar 11, 2024

@Ornias1993
Copy link
Member Author

Is this not in stable? https://github.com/truecharts/charts/blob/master/charts/stable/whisper-asr-webservice/values.yaml

Damnit, so why is this issue still open >.<
My mistake!

@Ornias1993 Ornias1993 closed this Mar 11, 2024
@truecharts truecharts deleted a comment from v3DJG6GL Mar 11, 2024
@Ornias1993 Ornias1993 reopened this Mar 11, 2024
@Ornias1993 Ornias1993 changed the title feat(whisper): add whisper chart feat(whishper ): add whishper hisper chart Mar 11, 2024
@Ornias1993 Ornias1993 changed the title feat(whishper ): add whishper hisper chart feat(whishper ): add whishper chart Mar 11, 2024
Copy link
Contributor

@xstar97 xstar97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill add the mongodb after all these changes

charts/incubator/whishper/values.yaml Outdated Show resolved Hide resolved
charts/incubator/whishper/Chart.yaml Outdated Show resolved Hide resolved
charts/incubator/whishper/Chart.yaml Outdated Show resolved Hide resolved
charts/incubator/whishper/Chart.yaml Outdated Show resolved Hide resolved
charts/incubator/whishper/Chart.yaml Outdated Show resolved Hide resolved
charts/incubator/whishper/Chart.yaml Outdated Show resolved Hide resolved
charts/incubator/whishper/values.yaml Outdated Show resolved Hide resolved
@Ornias1993
Copy link
Member Author

@xstar97 true does not have caps

Copy link

📝 Linting results:

✔️ Linting [charts/incubator/whishper]: Passed - Took 1 seconds
Total Charts Linted: 1
Total Charts Passed: 1
Total Charts Failed: 0

✅ Linting: Passed - Took 1 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add whishper
2 participants