fix: custom websocket server not upgrading due to next 13.4.3+ #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems next v13.4.3 added a breaking change that causes sockets to be closed when not handled by HMR. As a result, websocket connections fail to upgrade. I've applied a fix from the following thread to address this issue for now: vercel/next.js#50461 (comment)
trpc-bot
force-pushed
the
main
branch
6 times, most recently
from
95ff44b
to
ee7a675
Compare
trpc-bot
force-pushed
the
main
branch
12 times, most recently
from
f1b6658
to
c9d2a18
Compare
trpc-bot
force-pushed
the
main
branch
10 times, most recently
from
7eba023
to
1754bae
Compare
trpc-bot
force-pushed
the
main
branch
6 times, most recently
from
1b291b8
to
8422d7b
Compare
trpc-bot
force-pushed
the
main
branch
9 times, most recently
from
fe57b2a
to
53bbe40
Compare
trpc-bot
force-pushed
the
main
branch
5 times, most recently
from
b45abd4
to
67fe529
Compare
trpc-bot
force-pushed
the
main
branch
10 times, most recently
from
d69055f
to
e4f940c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems next v13.4.3 added a breaking change that causes sockets to be closed when not handled by HMR. As a result, websocket connections fail to upgrade. I've applied a fix from the following thread to address this issue for now:
vercel/next.js#50461 (comment)