Skip to content

Conversation

@wendigo
Copy link
Contributor

@wendigo wendigo commented Nov 27, 2025

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Nov 27, 2025
@wendigo wendigo requested a review from findepi November 27, 2025 18:49
@@ -0,0 +1 @@
java=25.0.1-tem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we keep various places in sync?
should we have a list of places to update when bumping JDK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We can list them

@findepi findepi requested a review from electrum November 27, 2025 19:18
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We intentionally limit the number of files in the project root to keep it organized and easier to browse.

The .java-version file already exists for the same purpose as this PR, and has the advantage of being self-describing. We don't need two files that specify the version for Java version managers.

@wendigo
Copy link
Contributor Author

wendigo commented Nov 28, 2025

@electrum I agree but that list is short. I don't use .java-version so I could raise a point that it's not useful for me. Same goes for .editorconfig. Why is one preferred over the other?

@electrum
Copy link
Member

The list is short because we worked hard to make it short and we are aggressive about keeping it short. If we say that "it's short, one more thing won't hurt" then it soon won't be short.

I see two options here:

  1. If sdkman is better than jenv, then convince the other developers who use jenv to switch, then swap/replace the config file.
  2. Send a PR to one or both of the projects to be compatible with the other one.

@electrum
Copy link
Member

.java-version is "preferred" because it was the first one added, by people who used it at the time. There wasn't any discussion about adding one or the other.

(I personally don't see the usefulness of having either one, as I use the latest Java as my default.)

.editorconfig is there for IntelliJ to configure things that for some reason can't set in code style (or that was true in the past), so you probably do use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants