-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add sdkmanrc with current Java version #27490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| @@ -0,0 +1 @@ | |||
| java=25.0.1-tem | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we keep various places in sync?
should we have a list of places to update when bumping JDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We can list them
electrum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We intentionally limit the number of files in the project root to keep it organized and easier to browse.
The .java-version file already exists for the same purpose as this PR, and has the advantage of being self-describing. We don't need two files that specify the version for Java version managers.
|
@electrum I agree but that list is short. I don't use .java-version so I could raise a point that it's not useful for me. Same goes for .editorconfig. Why is one preferred over the other? |
|
The list is short because we worked hard to make it short and we are aggressive about keeping it short. If we say that "it's short, one more thing won't hurt" then it soon won't be short. I see two options here:
|
|
(I personally don't see the usefulness of having either one, as I use the latest Java as my default.)
|
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: