Improve logging in HiveSplitManager #25467
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
| @@ -357,7 +357,7 @@ private Iterator<HivePartitionMetadata> getPartitionMetadata( | |||
| throw new TrinoException(GENERIC_INTERNAL_ERROR, "Partition not loaded: " + hivePartition); | |||
| } | |||
| if (partition.isEmpty()) { | |||
| throw new TrinoException(HIVE_PARTITION_DROPPED_DURING_QUERY, "Partition no longer exists: " + hivePartition.getPartitionId()); | |||
| throw new TrinoException(HIVE_PARTITION_DROPPED_DURING_QUERY, format("Partition %s no longer exists for %s", hivePartition.getPartitionId(), tableName)); | |||
There was a problem hiding this comment.
Why do we fix only this line? There are other TrinoException usages without a table name in this class.
There was a problem hiding this comment.
There are hundreds (sometimes even thousands) of exceptions with this exact text and there is no way to find for which table(s).
There was a problem hiding this comment.
For code consistency we should add table name to the exceptions thrown from this method
...rino-hive/src/test/java/io/trino/plugin/hive/metastore/glue/TestCachedHiveGlueMetastore.java
Show resolved
Hide resolved
ebyhr
changed the title
Angel-Asensio
force-pushed
the
improve_logging
branch
from
3f7e215 to
8b951ca
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.