Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase error message for MethodTooLargeException #25463

Conversation

losipiuk
Copy link
Member

Previous exception message for MethodTooLargeException was too specific and was misleading at times.

@losipiuk losipiuk added the no-release-notes This pull request does not require release notes entry label Mar 31, 2025
@cla-bot cla-bot bot added the cla-signed label Mar 31, 2025
@losipiuk losipiuk requested a review from wendigo March 31, 2025 09:59
Copy link
Contributor

@wendigo wendigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/translate/compile

@losipiuk losipiuk force-pushed the lukaszos/rephrase-error-message-for-methodtoolargeexception-08834b branch from 369200c to 75cee16 Compare March 31, 2025 10:36
@losipiuk
Copy link
Member Author

s/translate/compile

Let's keep translate. It is for end-user after all.

Previous exception message for MethodTooLargeException was too specific
and was misleading at times.
@losipiuk losipiuk force-pushed the lukaszos/rephrase-error-message-for-methodtoolargeexception-08834b branch from 75cee16 to 20ed931 Compare March 31, 2025 11:30
@losipiuk losipiuk merged commit d967d71 into trinodb:master Mar 31, 2025
93 of 94 checks passed
@github-actions github-actions bot added this to the 475 milestone Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

2 participants