Allow configuration to disable migrations

[naman-patel]

Description

Adding a flag that, during startup, disables migrations for resource groups when DB resource group store is enabled.

Additional context and related issues

There is a need for us to not use migrations and make database changes manually. This flag allows us to not run migrations and use the same behavior that exists in trino gateway.

Release notes

## Section
* When the configured user does not have DDL privileges we want to be able to disable migration and run SQL updates manually. 

[mosabua]

Maybe we should NOT be merging this .. at this stage we are planning to remove the resource group tables and their management in Trino Gateway so there might not be a problem to solve here .. unless this is trying to solve some other issue.

[Copilot]

Pull Request Overview

This PR introduces a configuration flag to disable automatic database migrations when managing resource groups. The key changes include:

• Adding a new configuration property (runMigrationsEnabled) with a default value of true.
• Updating the resource group configuration manager to conditionally run Flyway migrations based on the flag.
• Extending test cases to verify both default and explicit behavior of the new migration flag.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
plugin/trino-resource-group-managers/src/test/java/io/trino/plugin/resourcegroups/db/TestDbResourceGroupConfig.java	Updates tests to account for the new migration flag in both default and explicit property mappings
plugin/trino-resource-group-managers/src/main/java/io/trino/plugin/resourcegroups/db/DbResourceGroupConfigurationManagerFactory.java	Modifies the factory to conditionally invoke migrations based on the configuration flag
plugin/trino-resource-group-managers/src/main/java/io/trino/plugin/resourcegroups/db/DbResourceGroupConfig.java	Introduces the runMigrationsEnabled property with getter and setter methods

Comments suppressed due to low confidence (1)

plugin/trino-resource-group-managers/src/main/java/io/trino/plugin/resourcegroups/db/DbResourceGroupConfigurationManagerFactory.java:45

• Consider adding a unit test to verify that migrations are not triggered when runMigrationsEnabled is set to false.

if (resourceGroupConfig.isRunMigrationsEnabled()) {

[naman-patel]

Maybe we should NOT be merging this .. at this stage we are planning to remove the resource group tables and their management in Trino Gateway so there might not be a problem to solve here .. unless this is trying to solve some other issue.

We use resource groups in our production heavily. Is there any alternates that is planned to replace resource groups?

[willmostly]

We use resource groups in our production heavily. Is there any alternates that is planned to replace resource groups?

To be clear, the removal of the resource group management UI from Trino Gateway will not have any impact on support for Resource Groups in Trino. You may continue to use them in clusters behind the Trino Gateway without issue.

[willmostly]

There are a few reasons for removal:

• Resource Groups are not used by the Trino Gateway, so they cannot be properly tested
• Managing a Trino component through the Gateway introduces coupling that can cause issues such as issue #637
• Our current test framework has no capability for testing Trino Gateway against different Trino versions, so we will be unaware of any compatibility issues
• The existing implementation can create an incorrect impression that Trino Gateway uses resource groups for load balancing and routing, which it does not

Considering these factors, the convenience of the reource group UI does not justify the maintenance overhead and potential for issues.

[naman-patel]

There are a few reasons for removal:

* Resource Groups are not used by the Trino Gateway, so they cannot be properly tested

* Managing a Trino component through the Gateway introduces coupling that can cause issues such as [issue #637](https://github.com/trinodb/trino-gateway/issues/637)

* Our current test framework has no capability for testing Trino Gateway against different Trino versions, so we will be unaware of any compatibility issues

* The existing implementation can create an incorrect impression that Trino Gateway uses resource groups for load balancing and routing, which it does not

Considering these factors, the convenience of the reource group UI does not justify the maintenance overhead and potential for issues.

None the less, if the user does not have DDL privileges, we need to be able to disable this. Some of the migrations are not written as ALTER TABLE XXX ADD COLUMN IF NOT EXISTS ... its just ALTER TABLE XXX ADD COLUMN ... I am just trying to see if we can disable the migration.

[mosabua]

Fair enough @naman-patel .. I think we can go ahead with this PR from that perspective.

[mosabua]

Kinda but not really related to trinodb/trino-gateway#656

[mosabua]

I am good with this change now. Overall I feel like the db resource group manager is in bad shape though. There are nearly no docs and the config properties are all over the map.

If we eventually get this supported by the UI we will need to also fix up the config property names for consistency and add docs, but for now this PR is fine by me. Thoughts @wendigo ?

It would be great if @naman-patel and any other users of it could potentially help adding docs and fixing properties in follow up PRs.

[naman-patel]

I am good with this change now. Overall I feel like the db resource group manager is in bad shape though. There are nearly no docs and the config properties are all over the map.

If we eventually get this supported by the UI we will need to also fix up the config property names for consistency and add docs, but for now this PR is fine by me. Thoughts @wendigo ?

It would be great if @naman-patel and any other users of it could potentially help adding docs and fixing properties in follow up PRs.

I would be ok to get things started. Where are the docs located. Let me know and how can I contribute to that.