Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs for table statistics #24892

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Feb 3, 2025

Description

Result of chat in #24874 with @nineinchnick

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

Copy link
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also noticed we don't mention anywhere on this page that the statistics are estimates. It might not be obvious to everyone that they're not supposed to be fully accurate.

docs/src/main/sphinx/optimizer/statistics.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/optimizer/statistics.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/optimizer/statistics.md Outdated Show resolved Hide resolved
@mosabua
Copy link
Member Author

mosabua commented Feb 4, 2025

All addressed @nineinchnick

Copy link
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

docs/src/main/sphinx/optimizer/statistics.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/optimizer/statistics.md Outdated Show resolved Hide resolved
@mosabua
Copy link
Member Author

mosabua commented Feb 6, 2025

Quick glance @martint ?

@mosabua mosabua merged commit 60c5f2d into trinodb:master Feb 6, 2025
8 checks passed
@mosabua mosabua deleted the stats branch February 6, 2025 01:23
@github-actions github-actions bot added this to the 470 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants