Deprecate support for IBM COS via Hive #24870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
commented
Jan 31, 2025
| @@ -10,6 +10,7 @@ connector/atop.md connector/removed.md | |||
| connector/localfile.md connector/removed.md | |||
| connector/accumulo.md connector/removed.md | |||
| connector/kinesis.md connector/removed.md | |||
| object-storage/legacy-cos.md object-storage/file-system-s3.md | |||
There was a problem hiding this comment.
we only have that support via the S3 support now .. and thats better anyway. If we add tests we could add something to the S3 page .. but not without it.
|
Looks like that passes CI now .. so we could go ahead with merge. |
wendigo
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed with @electrum @wendigo and others .. this is a first deprecation. Removal will happen later this year as announced last year.
Turns out deprecating the properties makes the tests fail .. so should we remove the related tests now @electrum as part of deprecating the properties?
Additional context and related issues
Release notes
(x) Release notes are required, with the following suggested text: