Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for filtering queries by client tags in the Web UI #24494

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nazarii
Copy link

@Nazarii Nazarii commented Dec 16, 2024

Description

Currently it is not possible to filter out queries in the Web UI by the client tags values which becomes annoying to find specific queries when there are 30 of them running in parallel. This change adds support to filter queries by client tags in Web UI by modifying the api/query endpoint response to include additional value and adapting the UI part to do filtering.

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( x) Release notes are required, with the following suggested text:
Add support for filtering by query client tags in the Web UI.

Copy link

cla-bot bot commented Dec 16, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the ui Web UI label Dec 16, 2024
Copy link

cla-bot bot commented Dec 16, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@Nazarii Nazarii changed the title Add support for filtering by client tags in Web UI Add support for filtering queries by client tags in Web UI Dec 16, 2024
@Nazarii Nazarii changed the title Add support for filtering queries by client tags in Web UI Add support for filtering queries by client tags in the Web UI Dec 16, 2024
@Nazarii Nazarii force-pushed the client-tags-filtering branch from b9830ec to 543b1fa Compare December 16, 2024 23:08
Copy link

cla-bot bot commented Dec 16, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ebyhr ebyhr requested a review from wendigo December 17, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Web UI
Development

Successfully merging this pull request may close these issues.

1 participant