Autocomplete: Add position prop #2846
Conversation
❌ Deploy Preview for moduswebcomponents failed. Why did it fail? →
|
There was a problem hiding this comment.
@ElishaSamPeterPrabhu Once I select an option from the bottom of the list, I'm not able to change it.
User.Inputs._.Autocomplete.-.Default.Storybook.-.Google.Chrome.2024-09-12.00-17-54.mp4
Added animation change as fix |
ElishaSamPeterPrabhu
force-pushed
the
2801-autocomplete-add-position-property-to-control-component-placement-relative-to-the-wrapped-item
branch
from
8604b9d
to
d6ba058
Compare
|
|
||
| initializePopper(): void { | ||
| const optionsContainer = this.el.shadowRoot.querySelector(`.options-container`) as HTMLElement; | ||
| const referenceElement = this.el as HTMLElement; |
There was a problem hiding this comment.
Can we use the chips-container as reference element? Otherwise the dropdown will be positioned based on the entire container height.
|
|
||
| this.popperInstance = createPopper(referenceElement, optionsContainer, { | ||
| placement: 'bottom-start', | ||
| strategy: this.position === 'auto' ? 'fixed' : 'absolute', |
There was a problem hiding this comment.
can you add a comment about why we use fixed strategy for auto position
There was a problem hiding this comment.
Also if I set position to auto, options container width is not restricted to the input width.
…onent-placement-relative-to-the-wrapped-item' of https://github.com/trimble-oss/modus-web-components into 2801-autocomplete-add-position-property-to-control-component-placement-relative-to-the-wrapped-item
This reverts commit ec9a0b4.
Description
References
Fixes #2801
Type of change
How Has This Been Tested?
Checklist