Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toasts: Updated to Match Figma #2708

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

coliff
Copy link
Member

@coliff coliff commented Jul 19, 2024

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

https://deploy-preview-2708--moduswebcomponents.netlify.app/?path=/docs/components-toast--primary

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@coliff coliff linked an issue Jul 19, 2024 that may be closed by this pull request
Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit e738228
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/669c8953afe6d50008899750
😎 Deploy Preview https://deploy-preview-2708--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 23 (🟢 up 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff coliff marked this pull request as draft July 19, 2024 12:05
@coliff coliff force-pushed the 2625-toasts-updated-to-match-figma branch from 2778cf7 to 65bed19 Compare July 21, 2024 04:00
@coliff coliff marked this pull request as ready for review July 21, 2024 04:09
@coliff coliff changed the title Toasts Updated to Match Figma Toasts: Updated to Match Figma Jul 22, 2024
@cjwinsor cjwinsor merged commit 658b6e5 into main Jul 23, 2024
11 checks passed
@cjwinsor cjwinsor deleted the 2625-toasts-updated-to-match-figma branch July 23, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toasts Updated to Match Figma
2 participants