Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch: Completely remove aria-checked from switch, set id on input to be the same as label, replace brittle unit test with more precise e2e test #2455

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Switch: Completely remove aria-checked from switch, set id on input to be the same as label, replace brittle unit test with more precise e2e test #2455

wants to merge 7 commits into from

Commits on Apr 20, 2024

  1. Replace brittle unit test with e2e test that more precisely tests the… 

    … behavior
    Austin O'Neil authored and Austin O'Neil committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    cf258e0 View commit details
    Browse the repository at this point in the history

  2. Made requested changes

    Austin O'Neil authored and Austin O'Neil committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    731e869 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Add check to e2e test

    Austin O'Neil authored and Austin O'Neil committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9013ebe View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. add id to switch, label

    Austin O'Neil authored and Austin O'Neil committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    e78f617 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Merge branch 'main' into switch-requested-updates

    @austinoneil
    austinoneil authored May 5, 2024
    Configuration menu
    Copy the full SHA
    71fa62a View commit details
    Browse the repository at this point in the history

  2. delete duplicate checked

    @austinoneil
    austinoneil committed May 5, 2024
    Configuration menu
    Copy the full SHA
    d2aac04 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. add lint disabling for h import

    @austinoneil
    austinoneil committed May 7, 2024
    Configuration menu
    Copy the full SHA
    6cba23c View commit details
    Browse the repository at this point in the history