Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing instructions #1121

Merged

Conversation

codenem
Copy link
Contributor

@codenem codenem commented May 22, 2024

Ran into an issue while trying to execute the CLI binary for the first time:

➜ v3-catalog [main|✔] pnpm exec triggerdev login -a http://localhost:3030 --profile local
 ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL  Command "triggerdev" not found

Ran into an issue while building the references/v3-catalog project locally:

➜ v3-catalog [main|✔] pnpm exec triggerdev dev --profile local

Trigger.dev (3.0.0-beta.33)
------------------------------------------------------
Key: Version | Task | Run
------------------------------------------------------
○ Building background worker…
X Error: Worker failed to start Error: The OPENAI_API_KEY environment variable is missing or empty; either provide it, or instantiate the OpenAI client with an apiKey option, like new OpenAI({ apiKey: 'My API Key' }).
    at new OpenAI (/Users/nem/code/trigger.dev/node_modules/.pnpm/[email protected]/node_modules/openai/src/index.ts:112:13)
    at Object.<anonymous> (/Users/nem/code/trigger.dev/references/v3-catalog/src/trigger/openai.ts:5:16)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Function.Module._load (node:internal/modules/cjs/loader:1023:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12)
    at node:internal/main/run_main_module:28:49

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

Reran the commands from the instructions successfully after applying the proposed changes.


Changelog

  • Updated the .env.example file in the references/v3-catalog directory
  • Updated the CONTRIBUTING.md file prerequisites and first-time setup instructions

Screenshots

[Screenshots]

💯

Copy link

changeset-bot bot commented May 22, 2024

⚠️ No Changeset found

Latest commit: 15c5106

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codenem codenem force-pushed the update-contributing-instructions branch from ca216e1 to 15c5106 Compare May 22, 2024 14:03
@ericallam ericallam merged commit c815f28 into triggerdotdev:main May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants