-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to .NET 5.0 and WCT MVVM #6
Open
jzebedee
wants to merge
45
commits into
trigger-segfault:master
Choose a base branch
from
jzebedee:wct-mvvm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the extra "Wpf debug" and "Wpf release" configurations, as well as fixing the NtfsReader being set to Release in the default Debug profile
Target .NET Framework 4.8
Remove WinForms and Aero references Add Microsoft.Extensions.DependencyInjection package reference Add Ookii.Dialogs package reference
These types now wrap the WCT RelayCommand types by composition, rather than inheriting from them
Use the Microsoft.Extensions.DependencyInjection IOC implementation
Here's the WCT MVVM documentation for migrating from MvvmLight. The changes should be in line with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all projects to .NET 5.0, including replacing the old .NET Framework MvvmLight with the Windows Community Toolkit MVVM library.
There's an
.editorconfig
that tries to mimic the original coding style, so I hope there won't be too many style-only changes popping up.Because the APIs in NET 5.0 already require
windows-7.0
or higher, I removed the WinForms dependency (which was only used for a dialog box) and replaced it with a .NET Standard provider.