wip#28250
Draft
karliatto wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notes for QA
Related Issue
Resolve
Screenshots:
🤖 LLM Test Recommendations
Summary: The change is isolated to
overloadHttpRequest.tsin therequest-managerpackage, which handles HTTP request interception (likely for Tor proxy routing). There is no static test coverage mapping available for this file, so all recommendations are inferred. The bridge/tor test is the most directly relevant since it exercises network infrastructure closest to the request-manager's domain. Trading tests are included at low priority as they exercise HTTP API calls that could be affected by request interception changes. Overall risk is moderate — the change could silently affect any outgoing HTTP request behavior, but without knowing the exact nature of the change, targeted testing of network-dependent features is the best strategy.Changed files (1)
packages/request-manager/src/interceptor/overloadHttpRequest.tsRecommended tests (3)
🟡 Medium priority (1)
suite/e2e/tests/bridge-tor/spawn-bridge-daemon.test.ts— The changed fileoverloadHttpRequest.tsinpackages/request-manageris part of the HTTP request interception/proxy layer, which is closely related to Tor and bridge connectivity infrastructure. This test exercises the bridge daemon spawning and HTTP health checks against the bridge endpoint, which could be affected if HTTP request overloading behavior changes.🟢 Low priority (2)
suite/e2e/tests/trading/buy-bitcoin.test.ts— The request-manager's HTTP interceptor could affect how outgoing API requests to the Invity trading backend are handled. This test makes multiple mocked HTTP requests (buyQuotes, buyTrade, buyWatch) and verifies payloads, making it sensitive to changes in HTTP request interception behavior.suite/e2e/tests/trading/swap-coins.test.ts— This swap test involves multiple HTTP requests to Invity swap endpoints and watch polling, exercising the HTTP request pipeline thatoverloadHttpRequest.tsintercepts. Changes to request overloading could affect how swap API calls are routed or proxied.packages/request-manager/src/interceptor/overloadHttpRequest.tsUpdated: 2026-06-01T19:02:14.514Z
🔍 Currents Test Results
🔍 Suite desktop test results: View in Currents
🔍 Suite web test results: View in Currents
🔒 Quarantined E2E Tests
Trezor Suite (web) — 9 test(s)
Updated: 2026-06-01T19:08:08.643Z • 9 test(s) total
Trezor Suite (desktop) — 3 test(s)
Updated: 2026-06-01T19:05:51.913Z • 3 test(s) total
🌐 Preview deployments
🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/fix/request-manager-update-second/web/