Skip to content

fix(suite): persist legacy label migration by wallet#28231

Draft
peter-sanderson wants to merge 4 commits into
developfrom
implicit-legacy-to-suite-sync-migration
Draft

fix(suite): persist legacy label migration by wallet#28231
peter-sanderson wants to merge 4 commits into
developfrom
implicit-legacy-to-suite-sync-migration

Conversation

@peter-sanderson
Copy link
Copy Markdown
Contributor

@peter-sanderson peter-sanderson commented Jun 1, 2026

Resolves #28176

Set a persisted metadata flag for wallets whose legacy labels were migrated and mark it after successful migration regardless of provider.

Screencast.from.2026-06-01.16-58-48.mp4

Testing

  • eject wallet (or wipe suite if yolo)
  • connect wallet
  • turn on legacy labeling and have some data in there
  • turn on suite sync (doesn't matter how, test all entry-points 🙏 )
  • after a while, you got notification that you have migrated some labels
  • if no labels migrated, no banner (in contrast win settings-migrate where you see the "migrated: 0, skipped: 22)

🔍 Currents Test Results

🔍 Suite desktop test results: View in Currents

🔍 Suite web test results: View in Currents

🔍 Suite native android test results: View in Currents

🔒 Quarantined E2E Tests

Trezor Suite (web) — 9 test(s)
Test Type
Account metadata > dropbox provider 🤖 auto
Passphrase with cardano > verify cardano address behind passphrase 🤖 auto
Cardano > Basic cardano walkthrough 🤖 auto
Public Keys > Check ada XPUB 🤖 auto
Account types suite > Add-account-types-non-BTC-coins 🤖 auto
Quarantine test: "Onboarding - create wallet,Success (basic)" 🙋 manual
Quarantine test: "Database migration,Db migration between: release/22.5/web => develop/web" 🙋 manual
Quarantine test: "Multiple sessions,Session overtaken by another" 🙋 manual
Quarantine test: "Recovery T2T1 - dry run,Recovery after partial recovery" 🙋 manual

Updated: 2026-06-01T15:28:09.673Z • 9 test(s) total

Trezor Suite (desktop) — 4 test(s)
Test Type
Account types suite > Add-account-types-non-BTC-coins 🤖 auto
Passphrase with cardano > verify cardano address behind passphrase 🤖 auto
Onboarding - create wallet > Success (basic) 🤖 auto
Quarantine test: "Multiple sessions,Session overtaken by another" 🙋 manual

Updated: 2026-06-01T12:03:17.130Z • 4 test(s) total

🌐 Preview deployments

🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/implicit-legacy-to-suite-sync-migration/web/

@peter-sanderson peter-sanderson force-pushed the implicit-legacy-to-suite-sync-migration branch 2 times, most recently from d56404b to 4a4813e Compare June 1, 2026 13:22
@trezor-bot
Copy link
Copy Markdown
Contributor

trezor-bot Bot commented Jun 1, 2026

✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

@trezor-bot
Copy link
Copy Markdown
Contributor

trezor-bot Bot commented Jun 1, 2026

✅ Previously successful run of [Test] suite-native Android E2E workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

@trezor-bot
Copy link
Copy Markdown
Contributor

trezor-bot Bot commented Jun 1, 2026

✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

Set a persisted metadata flag for wallets whose legacy labels were migrated and mark it after successful migration regardless of provider.\n\nRefs #28176
@peter-sanderson peter-sanderson force-pushed the implicit-legacy-to-suite-sync-migration branch 3 times, most recently from 8f63b44 to 4c794c9 Compare June 1, 2026 14:53
@peter-sanderson peter-sanderson force-pushed the implicit-legacy-to-suite-sync-migration branch from 4c794c9 to f804509 Compare June 1, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-migration of labels from legacy labeling is missing

1 participant