Skip to content

Feat/connect authenticity proof streaming#27998

Merged
szymonlesisz merged 3 commits into
developfrom
feat/connect-authenticity-proof-streaming
Jun 1, 2026
Merged

Feat/connect authenticity proof streaming#27998
szymonlesisz merged 3 commits into
developfrom
feat/connect-authenticity-proof-streaming

Conversation

@szymonlesisz
Copy link
Copy Markdown
Contributor

@szymonlesisz szymonlesisz commented May 25, 2026 •
edited by trezor-bot Bot
Loading

Description

following trezor/trezor-firmware#6961

add stream param to AuthenticateDevice.

add streamimg chunks: GetAuthenticityProofChunk => AuthenticityProofChunk | Success

Notes for QA

this could be tested only in limited setup

🔍 Currents Test Results

🔍 Suite desktop test results: View in Currents

🔍 Suite web test results: View in Currents

🔍 Suite native android test results: View in Currents

🔒 Quarantined E2E Tests

Trezor Suite (web) — 15 test(s)
Test Type
Account metadata > dropbox - watches files over time 🤖 auto
Dropbox API errors > Incomplete data returned from provider 🤖 auto
Metadata - switching between cloud providers > Start with one and switch to another 🤖 auto
Metadata - address labeling > google provider 🤖 auto
Metadata lifecycle > Choice persistence and reset behavior 🤖 auto
Labeling migration > Migration from Dropbox 🤖 auto
Metadata - Output labeling > dropbox provider 🤖 auto
Remembered device > google provider 🤖 auto
Dropbox API errors > Malformed token 🤖 auto
Account metadata > dropbox provider 🤖 auto
Account metadata > google - watches files over time 🤖 auto
Quarantine test: "Onboarding - create wallet,Success (basic)" 🙋 manual
Quarantine test: "Database migration,Db migration between: release/22.5/web => develop/web" 🙋 manual
Quarantine test: "Multiple sessions,Session overtaken by another" 🙋 manual
Quarantine test: "Recovery T2T1 - dry run,Recovery after partial recovery" 🙋 manual

Updated: 2026-05-25T08:56:44.366Z • 15 test(s) total

Trezor Suite (desktop) — 8 test(s)
Test Type
Suite Sync - Labelling > Create new labels 🤖 auto
Firmware - check readiness > Suite detects that firmware is ready 🤖 auto
Cardano > Basic cardano walkthrough 🤖 auto
Account types suite > Add-account-types-non-BTC-coins 🤖 auto
Passphrase with cardano > verify cardano address behind passphrase 🤖 auto
Public Keys > Check ada XPUB 🤖 auto
Onboarding - create wallet > Success (basic) 🤖 auto
Quarantine test: "Multiple sessions,Session overtaken by another" 🙋 manual

Updated: 2026-05-26T09:20:21.166Z • 8 test(s) total

🌐 Preview deployments

🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/feat/connect-authenticity-proof-streaming/web/

@szymonlesisz szymonlesisz force-pushed the feat/connect-authenticity-proof-streaming branch from 5ed6c87 to 00d798f Compare May 26, 2026 09:15
@trezor-bot
Copy link
Copy Markdown
Contributor

trezor-bot Bot commented May 26, 2026 •
edited
Loading

✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

@trezor-bot
Copy link
Copy Markdown
Contributor

trezor-bot Bot commented May 26, 2026 •
edited
Loading

✅ Previously successful run of [Test] suite-native Android E2E workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

@szymonlesisz szymonlesisz added the connect Connect API related (ie. fee calculation) label May 26, 2026
@szymonlesisz szymonlesisz force-pushed the feat/connect-authenticity-proof-streaming branch 2 times, most recently from 3bf5eed to 3dd7e74 Compare May 26, 2026 11:25
@szymonlesisz szymonlesisz marked this pull request as ready for review May 26, 2026 11:26
@szymonlesisz szymonlesisz requested a review from Copilot May 26, 2026 11:26
Copilot AI reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@szymonlesisz szymonlesisz requested a review from Copilot May 26, 2026 12:48
Copilot AI reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comment thread packages/connect/src/api/authenticateDevice.ts Outdated
Comment thread packages/connect/src/api/authenticateDevice.ts Outdated
Comment thread packages/connect-cli/src/index.ts
@szymonlesisz szymonlesisz requested a review from Copilot May 26, 2026 14:04
Copilot AI reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comment thread packages/connect/src/api/authenticateDevice.ts
Comment thread packages/connect/src/api/authenticateDevice.ts
@szymonlesisz szymonlesisz mentioned this pull request May 27, 2026
Merged
@szymonlesisz
Copy link
Copy Markdown
Contributor Author

szymonlesisz commented May 27, 2026

/rebase

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/26520949748

@trezor-bot trezor-bot Bot force-pushed the feat/connect-authenticity-proof-streaming branch from 2e423c7 to e1a06f3 Compare May 27, 2026 15:28
@szymonlesisz szymonlesisz force-pushed the feat/connect-authenticity-proof-streaming branch 2 times, most recently from bd956ed to 86b41ad Compare May 28, 2026 09:18
@szymonlesisz szymonlesisz force-pushed the feat/connect-authenticity-proof-streaming branch from 86b41ad to 2c02cbd Compare May 28, 2026 09:55
martykan
martykan approved these changes May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@martykan martykan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but did not test myself

Lemonexe
Lemonexe reviewed May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Lemonexe Lemonexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM, though I am not very knowledgable about transport (chunking)

Comment thread packages/connect/src/data/config.ts
},
{
capabilities: ['mcuDeviceAuthentication'],
capabilities: ['mcuDeviceAuthentication', 'authenticityProofChunk'],
Copy link
Copy Markdown
Contributor

@Lemonexe Lemonexe May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I got it now this is what you meant. Perfect 👌

@szymonlesisz szymonlesisz merged commit cfa7aee into develop Jun 1, 2026
58 checks passed
@szymonlesisz szymonlesisz deleted the feat/connect-authenticity-proof-streaming branch June 1, 2026 08:27
@trezor-bot trezor-bot Bot moved this to 🤝 Needs QA in Suite Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lemonexe Lemonexe Lemonexe left review comments

Copilot code review Copilot Copilot left review comments

@martykan martykan martykan approved these changes

@mroz22 mroz22 Awaiting requested review from mroz22 mroz22 is a code owner

@marekrjpolak marekrjpolak Awaiting requested review from marekrjpolak marekrjpolak is a code owner

Assignees

No one assigned

Labels

connect Connect API related (ie. fee calculation)

Projects

Suite
Status: 🤝 Needs QA

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@szymonlesisz @Lemonexe @martykan