Skip to content

chore(core): update communication-related strings#7042

Open
romanz wants to merge 1 commit into
mainfrom
romanz/2606/comm
Open

chore(core): update communication-related strings#7042
romanz wants to merge 1 commit into
mainfrom
romanz/2606/comm

Conversation

@romanz
Copy link
Copy Markdown
Contributor

@romanz romanz commented Jun 1, 2026

@romanz romanz self-assigned this Jun 1, 2026
@romanz romanz added the translations Put this label on a PR to run tests in all languages label Jun 1, 2026
@trezor-bot trezor-bot Bot added this to Firmware Jun 1, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b9daf8d1-036e-4a4c-b8fa-9d4dd2e4e461

📥 Commits

Reviewing files that changed from the base of the PR and between c190a98 and c4e1083.

⛔ Files ignored due to path filters (1)
  • core/embed/rust/src/translations/generated/translated_string.rs is excluded by !**/generated/**
📒 Files selected for processing (6)
  • core/embed/rust/librust_qstr.h
  • core/mocks/trezortranslate_keys.pyi
  • core/translations/en.json
  • core/translations/order.json
  • core/translations/signatures.json
  • tests/ui_tests/fixtures.json

Walkthrough

This PR adds a new English translation string words__comm_continue for device communication scenarios. The change flows through the translation infrastructure: the new string is added to en.json with updated messaging for device communication failures, registered in the translation order index, declared in Python type stubs, registered as a Rust QSTR symbol, and results in updated test fixture hashes across all device variant test suites.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • matejcik
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description provides references to related discussion and design, but lacks detailed explanation of what was changed and why. Add a brief summary of the specific changes (e.g., which strings were updated) and the rationale for these updates to make the description more informative.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating communication-related translation strings across multiple files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch romanz/2606/comm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-project-automation github-project-automation Bot moved this to 🔎 Needs review in Firmware Jun 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)
Translations

cs main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

de main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

es main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

fr main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

pt main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

Latest CI run: 26762290758

@romanz romanz force-pushed the romanz/2606/comm branch from 6fab394 to c4e1083 Compare June 1, 2026 14:46
@romanz romanz marked this pull request as ready for review June 1, 2026 14:46
@romanz romanz requested review from matejcik and obrusvit as code owners June 1, 2026 14:46
@romanz romanz requested a review from Thalarion June 1, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translations Put this label on a PR to run tests in all languages

Projects

Status: 🔎 Needs review

Development

Successfully merging this pull request may close these issues.

1 participant