Fix tropic int pin#6955
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis pull request updates the TROPIC01 interrupt GPIO configuration across all three Trezor T3W1 board revision headers. The changes uniformly redirect the interrupt signal from GPIOB pin 11 to GPIOD pin 8, updating the corresponding port, pin, and HAL clock-enable macro in each board definition file (revA, revB, and revC). Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| model | device_test | click_test | persistence_test |
|---|---|---|---|
| T2T1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
| T3B1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
| T3T1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
| T3W1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
Latest CI run: 26171593008
[no changelog] It was fixed according to: https://github.com/trezor/trezor-hardware/blob/master/electronics/trezor_safe_7/ts7_main_rev_d_sch.pdf This pin has not been used so far.
fd65da8 to
bd00828
Compare
|
I think that tropic fw version we used at start of production did not support the int pin. Did you test the fix with some newer version of tropic fw that has the support implemented? Also, due to the limitation of original fw, we did not test this pin during production, so there is some possibility that some of already produced devices would not work correctly when this pin is used. |
TychoVrahe
left a comment
There was a problem hiding this comment.
The pin config change looks correct in any case.
That would explain it. Anyway, it looks like we won’t need the pin for now. |




































I discovered this bug when I tried to speed up Tropic communication by using the int pin (see https://github.com/tropicsquare/libtropic/blob/v4.0.0/hal/stm32/stm32u5xx/libtropic_port_stm32u5xx.c#L196). Even after the fix, it behaved as though the pin were never high. So I chose a different way to speed up the communication: #6956