Skip to content

Fix tropic int pin#6955

Merged
onvej-sl merged 1 commit into
mainfrom
onvej-sl/fix-tropic-pin
May 22, 2026
Merged

Fix tropic int pin#6955
onvej-sl merged 1 commit into
mainfrom
onvej-sl/fix-tropic-pin

Conversation

@onvej-sl
Copy link
Copy Markdown
Contributor

@onvej-sl onvej-sl commented May 20, 2026

I discovered this bug when I tried to speed up Tropic communication by using the int pin (see https://github.com/tropicsquare/libtropic/blob/v4.0.0/hal/stm32/stm32u5xx/libtropic_port_stm32u5xx.c#L196). Even after the fix, it behaved as though the pin were never high. So I chose a different way to speed up the communication: #6956

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b37bb4bf-da85-4992-b01d-57695aedfd95

📥 Commits

Reviewing files that changed from the base of the PR and between 6704563 and bd00828.

📒 Files selected for processing (3)
  • core/embed/models/T3W1/boards/trezor_t3w1_revA.h
  • core/embed/models/T3W1/boards/trezor_t3w1_revB.h
  • core/embed/models/T3W1/boards/trezor_t3w1_revC.h

Walkthrough

This pull request updates the TROPIC01 interrupt GPIO configuration across all three Trezor T3W1 board revision headers. The changes uniformly redirect the interrupt signal from GPIOB pin 11 to GPIOD pin 8, updating the corresponding port, pin, and HAL clock-enable macro in each board definition file (revA, revB, and revC).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description lacks required sections from the template such as development status labels, project assignment, priority, team, and sprint information. However, it provides meaningful context about the bug discovery and rationale for the fix. Add required sections including assignment, project setup (Firmware project with Priority/Team/Sprint), and development status (set to 'Needs Review' for final PRs). Include QA notes if the fix is testable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix tropic int pin' is concise and directly describes the main change: correcting the TROPIC01 interrupt pin GPIO configuration across three board header files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch onvej-sl/fix-tropic-pin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@trezor-bot trezor-bot Bot added this to Firmware May 20, 2026
@github-project-automation github-project-automation Bot moved this to 🔎 Needs review in Firmware May 20, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)

Latest CI run: 26171593008

@onvej-sl onvej-sl force-pushed the onvej-sl/fix-tropic-pin branch from fd65da8 to bd00828 Compare May 20, 2026 15:10
@onvej-sl onvej-sl marked this pull request as ready for review May 21, 2026 12:20
@onvej-sl onvej-sl requested a review from TychoVrahe as a code owner May 21, 2026 12:20
@TychoVrahe
Copy link
Copy Markdown
Contributor

I think that tropic fw version we used at start of production did not support the int pin. Did you test the fix with some newer version of tropic fw that has the support implemented?

Also, due to the limitation of original fw, we did not test this pin during production, so there is some possibility that some of already produced devices would not work correctly when this pin is used.

Copy link
Copy Markdown
Contributor

@TychoVrahe TychoVrahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pin config change looks correct in any case.

@onvej-sl onvej-sl merged commit 57f717e into main May 22, 2026
110 checks passed
@onvej-sl onvej-sl deleted the onvej-sl/fix-tropic-pin branch May 22, 2026 12:08
@trezor-bot trezor-bot Bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware May 22, 2026
@onvej-sl
Copy link
Copy Markdown
Contributor Author

I think that tropic fw version we used at start of production did not support the int pin.

That would explain it.

Anyway, it looks like we won’t need the pin for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🤝 Needs QA

Development

Successfully merging this pull request may close these issues.

2 participants