Skip to content

Adjust CI and core/Makefile for new build system#6951

Merged
cepetr merged 5 commits into
cepetr/cargo-buildfrom
mmilata/cargo-build
May 22, 2026
Merged

Adjust CI and core/Makefile for new build system#6951
cepetr merged 5 commits into
cepetr/cargo-buildfrom
mmilata/cargo-build

Conversation

@mmilata
Copy link
Copy Markdown
Member

@mmilata mmilata commented May 18, 2026

Base: #6802

  • old build system still available through core/Makefile.scons
  • CI uses the new one everywhere except rust unit tests

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f9d25a9d-710b-493c-b012-a6b604a74e06

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mmilata/cargo-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@trezor-bot trezor-bot Bot added this to Firmware May 18, 2026
@github-project-automation github-project-automation Bot moved this to 🔎 Needs review in Firmware May 18, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)

Latest CI run: 26279431757

@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 18, 2026

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@mmilata mmilata force-pushed the mmilata/cargo-build branch 11 times, most recently from f2235dc to 6a0ed8b Compare May 20, 2026 21:10
@mmilata mmilata changed the title [do not merge] new build system Adjust CI and core/Makefile for new build system May 20, 2026
@mmilata mmilata force-pushed the mmilata/cargo-build branch 7 times, most recently from 8e8b241 to 9ec2fd1 Compare May 21, 2026 15:46
@mmilata mmilata changed the base branch from main to cepetr/cargo-build May 21, 2026 15:59
@mmilata mmilata added core Trezor Core firmware. Runs on Trezor Model T and Safe models. ci Continuous Integration (CI) related code Code improvements no-QA On PR-merge, automatically transition status in the "Firmware" project to "Done (no QA)" state. labels May 21, 2026
@mmilata mmilata moved this from 🔎 Needs review to 🏃‍♀️ In progress in Firmware May 21, 2026
@mmilata mmilata force-pushed the mmilata/cargo-build branch 4 times, most recently from 1e9e9f8 to 79e7f5c Compare May 21, 2026 19:50
@mmilata mmilata marked this pull request as ready for review May 21, 2026 20:08
@mmilata mmilata requested review from cepetr and removed request for TychoVrahe May 21, 2026 20:09
@mmilata mmilata moved this from 🏃‍♀️ In progress to 🔎 Needs review in Firmware May 21, 2026
@cepetr cepetr force-pushed the cepetr/cargo-build branch from 3eea7e1 to ffe2eb1 Compare May 22, 2026 07:59
@cepetr cepetr requested a review from matejcik as a code owner May 22, 2026 07:59
Comment thread Makefile
Comment thread core/Makefile Outdated
@cepetr cepetr force-pushed the cepetr/cargo-build branch from ffe2eb1 to bd3c5a4 Compare May 22, 2026 08:54
mmilata and others added 5 commits May 22, 2026 11:18
[no changelog]

Co-authored-by: Martin Milata <martin@martinmilata.cz>
Old Makefile can still be used, e.g.:

  make -f Makefile.scons build_unix_frozen PYOPT=0

[no changelog]
@mmilata mmilata force-pushed the mmilata/cargo-build branch from 79e7f5c to bb16feb Compare May 22, 2026 09:19
@cepetr cepetr merged commit 71121c1 into cepetr/cargo-build May 22, 2026
110 checks passed
@cepetr cepetr deleted the mmilata/cargo-build branch May 22, 2026 11:27
@trezor-bot trezor-bot Bot moved this from 🔎 Needs review to ✅ Done (no QA) in Firmware May 22, 2026
@cepetr cepetr mentioned this pull request May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration (CI) related code Code improvements core Trezor Core firmware. Runs on Trezor Model T and Safe models. no-QA On PR-merge, automatically transition status in the "Firmware" project to "Done (no QA)" state.

Projects

Status: ✅ Done (no QA)

Development

Successfully merging this pull request may close these issues.

2 participants