[WIP] Test THP ACK piggybacking#6557
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can generate walkthrough in a markdown collapsible section to save space.Enable the |
f09d7d1 to
9da9dca
Compare
3373bf4 to
6023d44
Compare
9da9dca to
ea0800e
Compare
6023d44 to
b6490f6
Compare
ec77347 to
514fe62
Compare
514fe62 to
b51bfd8
Compare
ea0800e to
6075da0
Compare
6075da0 to
20a2a87
Compare
b51bfd8 to
1c17670
Compare
48efeb1 to
32d9001
Compare
This reverts commit 586df8a.
It allows scoping "interactive" context, where THP ACK piggybacking will be enabled. [no changelog]
`session.call_raw()` doesn't send a THP ACK when it is done, so the device will re-transmit the error message over and over. [no changelog]
Also rename ACK-sending methods, since "flushing" ACKs should not be skipped (otherwise the device may get stuck waiting for the ACK, while the host is waiting on DebugLink). [no changelog]
Used by translations & homescreen upload. [no changelog]
[no changelog]
[no changelog]
[no changelog]
1c17670 to
b6bfb8e
Compare
|
Closing in favor of #6594. |




























































































































































This reverts commit 586df8a and enabled host send-side THP ACK piggybacking for some interactive workflows.
See #6135 and #6506.