Skip to content

Drop support for python 3.9 in trezor-firmware#6548

Merged
M1nd3r merged 1 commit into
mainfrom
m1nd3r/drop-python-3-9
Mar 11, 2026
Merged

Drop support for python 3.9 in trezor-firmware#6548
M1nd3r merged 1 commit into
mainfrom
m1nd3r/drop-python-3-9

Conversation

@M1nd3r
Copy link
Copy Markdown
Contributor

@M1nd3r M1nd3r commented Mar 3, 2026

Note: Does not affect minimal required python versions of python-trezor (trezorlib, trezorctl) and other projects (e.g. toiftool).

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c3293d4a-b9db-4466-b9d5-d1b35381def6

📥 Commits

Reviewing files that changed from the base of the PR and between 61d6be4 and 20a5fff.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • docs/legacy/index.md
  • pyproject.toml
🚧 Files skipped from review as they are similar to previous changes (2)
  • pyproject.toml
  • docs/legacy/index.md

Walkthrough

The minimum Python version requirement was raised from >=3.9 to >=3.10 in pyproject.toml and the local development documentation (docs/legacy/index.md). The upper bound (<4) and all other configuration, dependencies, and code remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description provides important context clarifying that the change does not affect related projects, but does not follow the repository's template structure with required sections for core developer setup and development status. Clarify whether this PR follows the template requirements for core developers (project assignment, priority, team, sprint, development status) and include a 'Testable' or 'Not Testable' note for post-merge status.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change—dropping Python 3.9 support in trezor-firmware—which aligns with the modifications to pyproject.toml and documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch m1nd3r/drop-python-3-9

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@trezor-bot trezor-bot Bot added this to Firmware Mar 3, 2026
@github-project-automation github-project-automation Bot moved this to 🔎 Needs review in Firmware Mar 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 3, 2026

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)

Latest CI run: 22958802919

@M1nd3r M1nd3r marked this pull request as ready for review March 3, 2026 12:39
@M1nd3r M1nd3r requested a review from obrusvit as a code owner March 3, 2026 12:39
@M1nd3r M1nd3r requested a review from matejcik March 3, 2026 12:40
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
pyproject.toml (1)

6-6: Update stale Python version markers to align with the 3.10+ minimum.

The marker python_version >= '3.8' on line 55 (toiftool dependency) is now redundant given requires-python = ">=3.10,<4". Either simplify it to "toiftool" or update it to >= '3.10' for consistency. Additionally, docs/legacy/index.md references Python 3.9 as the minimum, which should be updated to 3.10.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@pyproject.toml` at line 6, Update dependency markers and docs to match the
declared Python range requires-python = ">=3.10,<4": remove or change the
redundant extras marker on the toiftool dependency (replace the conditional
marker python_version >= '3.8' with either no marker i.e. "toiftool" or update
it to python_version >= '3.10'), and update the minimum Python version text in
docs/legacy/index.md from 3.9 to 3.10 so documentation and dependency markers
are consistent with requires-python.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@pyproject.toml`:
- Line 6: Update dependency markers and docs to match the declared Python range
requires-python = ">=3.10,<4": remove or change the redundant extras marker on
the toiftool dependency (replace the conditional marker python_version >= '3.8'
with either no marker i.e. "toiftool" or update it to python_version >= '3.10'),
and update the minimum Python version text in docs/legacy/index.md from 3.9 to
3.10 so documentation and dependency markers are consistent with
requires-python.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bfe88d2 and 8394d8f.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml

@M1nd3r M1nd3r requested review from romanz March 3, 2026 13:03
@M1nd3r M1nd3r force-pushed the m1nd3r/drop-python-3-9 branch from 8394d8f to 61d6be4 Compare March 3, 2026 13:25
Copy link
Copy Markdown
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@M1nd3r M1nd3r force-pushed the m1nd3r/drop-python-3-9 branch from 61d6be4 to 20a5fff Compare March 11, 2026 14:53
@M1nd3r M1nd3r merged commit 898a4aa into main Mar 11, 2026
100 checks passed
@M1nd3r M1nd3r deleted the m1nd3r/drop-python-3-9 branch March 11, 2026 15:05
@github-project-automation github-project-automation Bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware Mar 11, 2026
@M1nd3r M1nd3r moved this from 🤝 Needs QA to ✅ Done (no QA) in Firmware Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants