Drop support for python 3.9 in trezor-firmware#6548
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe minimum Python version requirement was raised from >=3.9 to >=3.10 in pyproject.toml and the local development documentation (docs/legacy/index.md). The upper bound (<4) and all other configuration, dependencies, and code remain unchanged. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| model | device_test | click_test | persistence_test |
|---|---|---|---|
| T2T1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
| T3B1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
| T3T1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
| T3W1 | test(all) main(all) ![]() |
test(all) main(all) ![]() |
test(all) main(all) ![]() |
Latest CI run: 22958802919
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pyproject.toml (1)
6-6: Update stale Python version markers to align with the 3.10+ minimum.The marker
python_version >= '3.8'on line 55 (toiftool dependency) is now redundant givenrequires-python = ">=3.10,<4". Either simplify it to"toiftool"or update it to>= '3.10'for consistency. Additionally, docs/legacy/index.md references Python 3.9 as the minimum, which should be updated to 3.10.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pyproject.toml` at line 6, Update dependency markers and docs to match the declared Python range requires-python = ">=3.10,<4": remove or change the redundant extras marker on the toiftool dependency (replace the conditional marker python_version >= '3.8' with either no marker i.e. "toiftool" or update it to python_version >= '3.10'), and update the minimum Python version text in docs/legacy/index.md from 3.9 to 3.10 so documentation and dependency markers are consistent with requires-python.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pyproject.toml`:
- Line 6: Update dependency markers and docs to match the declared Python range
requires-python = ">=3.10,<4": remove or change the redundant extras marker on
the toiftool dependency (replace the conditional marker python_version >= '3.8'
with either no marker i.e. "toiftool" or update it to python_version >= '3.10'),
and update the minimum Python version text in docs/legacy/index.md from 3.9 to
3.10 so documentation and dependency markers are consistent with
requires-python.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml
8394d8f to
61d6be4
Compare
61d6be4 to
20a5fff
Compare




































Note: Does not affect minimal required python versions of python-trezor (trezorlib, trezorctl) and other projects (e.g. toiftool).