-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core) rename Shamir to Multi-share #3803
Conversation
|
Please merge after #3696 |
Don't we also want to rename the identifiers of strings? |
core/mocks/trezortranslate_keys.pyi
Outdated
@@ -601,15 +601,15 @@ class TR: | |||
reset__threshold_info: str = "= minimum number of unique word lists used for recovery." | |||
reset__title_backup_is_done: str = "BACKUP IS DONE" | |||
reset__title_create_wallet: str = "CREATE WALLET" | |||
reset__title_create_wallet_shamir: str = "CREATE WALLET (SHAMIR)" | |||
reset__title_create_wallet_shamir: str = "CREATE WALLET (MULTI-SHARE)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be visible also when user is creating 1 of 1 right?
During the creation of 1of1 shamir, there cannot be a term multi-share...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I'll use something else in that case. What should it be? "single share"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we now cannot distinguish which type of backup user would do (single-share or multi-share). So for now on deviceReset let's use just Create wallet as in bip39 flow.
2188ef3
to
954c02b
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the device tests fixtures for T2B1
are not updated as they do not currently run on CI. Compare the changed fixtures for T2B1
vs T2T1
.
I suggest updating those tests locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
[no changelog]
#3792 & #3793