feat(solana): add nullable tag #3801
Open
+162
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue raised in this issue. The issue was in parsing the message. The question remaining is wheter any optional parameter in messages that are being parsed will be the same as here the new authority(1 byte to denote wheter the value is set and then bytes with value) or it is possible that the value bytes are not there for optional parameters. This fix works for the latter, if the former is true the parsing of
is_optional
should be changed.This fix introduces a new flag
nullable
that for parsing purposes that reads and discards the value when the byte denotes that it is not set in the message.One more thing to note when trying to update the fixtures of ui tests, the script moves the
T3T1
part of the fixtures to the end of the file which creates a lot of line changes and it happened on multiple machines, therefore that change is not included int this PR, let me know wheter I should add it anyways.