hold to confirm animation for mercury ui #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/htc-anim
branch
from
902aa4c
to
ff59b1d
Compare
|
obrusvit
added
T3T1
and removed
blocked
obrusvit
reviewed
May 20, 2024
core/embed/rust/src/ui/model_mercury/flow/confirm_reset_create.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/model_mercury/component/hold_to_confirm.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/model_mercury/component/hold_to_confirm.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/model_mercury/component/hold_to_confirm.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/model_mercury/component/hold_to_confirm.rs
Outdated
Show resolved
Hide resolved
obrusvit
requested changes
May 20, 2024
core/embed/rust/src/ui/model_mercury/component/hold_to_confirm.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/model_mercury/component/hold_to_confirm.rs
Outdated
Show resolved
Hide resolved
obrusvit
approved these changes
May 21, 2024
| @@ -161,7 +161,7 @@ impl Component for Bip39Input { | |||
| let style = self.button.style(); | |||
|
|
|||
| // First, paint the button background. | |||
| self.button.render_background(target, style); | |||
| self.button.render_background(target, style, 0xFF); | |||
There was a problem hiding this comment.
Note: this line was removed in #3832 so it will cause conflict later.
| @@ -192,7 +192,7 @@ impl Component for Slip39Input { | |||
| let style = self.button.style(); | |||
|
|
|||
| // First, paint the button background. | |||
| self.button.render_background(target, style); | |||
| self.button.render_background(target, style, 0xFF); | |||
There was a problem hiding this comment.
Note: this line was removed in #3832 so it will cause conflict later.
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/htc-anim
branch
2 times, most recently
from
73c2df4
to
4808c34
Compare
TychoVrahe
changed the base branch from
ui-t3t1
to
tychovrahe/ui-t3t1/haptic_setting
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/htc-anim
branch
from
4808c34
to
2fbe4a0
Compare
obrusvit
reviewed
May 21, 2024
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/haptic_setting
branch
from
fda164d
to
ee43705
Compare
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/htc-anim
branch
from
2fbe4a0
to
38c6b52
Compare
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/haptic_setting
branch
3 times, most recently
from
d1bf5a3
to
b8409a3
Compare
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/htc-anim
branch
from
38c6b52
to
8c02187
Compare
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/htc-anim
branch
2 times, most recently
from
604c04b
to
6455f69
Compare
Base automatically changed from
tychovrahe/ui-t3t1/haptic_setting
to
tychovrahe/ui-t3t1/brightness
May 29, 2024 17:54
[no changelog]
[no changelog]
[no changelog]
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/htc-anim
branch
from
6455f69
to
25762fd
Compare
TychoVrahe
merged commit d0c02dd
into
tychovrahe/ui-t3t1/brightness
67 of 76 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds hold to confirm animation to mercury UI.
Draft for now, as it relies on several other PRs which should go in first, namely: #3775 #3763 , and also contains i2c fix that should be removed in the final PR.