Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): implement repeated backup. #3743

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

feat(core): implement repeated backup. #3743

wants to merge 25 commits into from

Conversation

ibz
Copy link
Contributor

@ibz ibz commented Apr 23, 2024 •
edited

Fixes #3640.

@ibz ibz self-assigned this Apr 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited

legacy UI changes device test(screens) main(screens)

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T2B1 Safe 3 3280 test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@ibz ibz force-pushed the ibz/20240411-custom-group-backup branch from f9bb3b1 to 39e10c4 Compare April 26, 2024 11:15
@ibz ibz force-pushed the ibz/20240423-repeated-backup branch from 2a9d92b to fc39cff Compare April 30, 2024 09:20
@ibz ibz force-pushed the ibz/20240411-custom-group-backup branch from 6dbb8c8 to 14ef89c Compare April 30, 2024 16:13
Base automatically changed from ibz/20240411-custom-group-backup to main May 1, 2024 07:23
@ibz ibz force-pushed the ibz/20240423-repeated-backup branch 15 times, most recently from 28066f6 to 1e6ed37 Compare May 3, 2024 10:18
@ibz ibz marked this pull request as ready for review May 3, 2024 10:47
matejcik
matejcik reviewed May 7, 2024
View reviewed changes
core/src/apps/management/recovery_device/__init__.py Outdated Show resolved Hide resolved
common/protob/messages-management.proto Outdated Show resolved Hide resolved
core/src/apps/management/recovery_device/__init__.py Outdated Show resolved Hide resolved
common/protob/messages-management.proto Outdated Show resolved Hide resolved
core/translations/order.json Outdated Show resolved Hide resolved
core/src/storage/recovery.py Outdated Show resolved Hide resolved
tests/click_tests/recovery.py Outdated Show resolved Hide resolved
tests/click_tests/recovery.py Outdated Show resolved Hide resolved
tests/click_tests/recovery.py Outdated Show resolved Hide resolved
tests/click_tests/recovery.py Outdated Show resolved Hide resolved
@ibz
Copy link
Contributor Author

ibz commented May 13, 2024

@Hannsek @matejcik When we trigger a recovery with "unlock repeated backup"... we ask the user how many words there are in the backup. But there can only be 20 or 33, right? So should the 12, 24 options still be there? :-/

@ibz ibz force-pushed the ibz/20240423-repeated-backup branch from 6558d37 to bc813e0 Compare May 29, 2024 06:31
ibz and others added 12 commits May 29, 2024 11:17
@ibz
ff
a1aba91
@ibz
fff
6b28e79
@ibz
ffff
95ed481
@ibz
fffff
64f5625
@ibz
f?
ab7d7ee
@ibz
comment
c301c0f
@ibz
c2
a256f1d
@ibz
f
0941bfd
@matejcik
wip: refactor(core/wire): move restarting control to handle_single_me…
77e24f5 
…ssage

that way it is possible to avoid restarting if we failed to find a
handler for a message (makes it faster with no ill effects because
"failed to find handler" (a) shouldn't happen and (b) doesn't cause any
significant fragmentation)
@ibz
Add test
c606ed8
@ibz
fix
291dd6f
@ibz
isort
5a36b52
matejcik
matejcik approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grdddj grdddj grdddj left review comments

@andrewkozlik andrewkozlik andrewkozlik left review comments

@matejcik matejcik matejcik approved these changes

@prusnak prusnak Awaiting requested review from prusnak prusnak is a code owner

Assignees

@ibz ibz

Labels
None yet
Projects
Firmware
Status: 🔎 Needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement repeated backup
5 participants
@ibz @Hannsek @andrewkozlik @matejcik @grdddj