-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only allow confirm-less firmware installation of full-trust images #3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TychoVrahe
force-pushed
the
tychovrahe/bootloader/confirmation
branch
from
April 12, 2024 20:45
431911f
to
996aeca
Compare
cepetr
requested changes
Aug 29, 2024
I don't see any problem with this change. Just add a note on how we can simplify the code a bit. |
TychoVrahe
force-pushed
the
tychovrahe/bootloader/confirmation
branch
from
August 29, 2024 11:41
996aeca
to
7673c3d
Compare
cepetr
requested changes
Aug 29, 2024
matejcik
approved these changes
Aug 30, 2024
cepetr
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
…for full-trust images
[no changelog]
[no changelog]
TychoVrahe
force-pushed
the
tychovrahe/bootloader/confirmation
branch
from
September 2, 2024 13:00
5197e2b
to
7cf7eb5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to empty devices only.
Now even when empty, installing fw without full trust requires user confirmation.