Skip to content

Commit

Permalink
chore(core): add missing parameter to set_brightness function
Browse files Browse the repository at this point in the history
  • Loading branch information
bieleluk committed Nov 29, 2024
1 parent 05f464f commit 217dd8c
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 4 deletions.
1 change: 1 addition & 0 deletions core/.changelog.d/4410.fixed
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add optional value parameter in brightness setting flow.
4 changes: 2 additions & 2 deletions core/src/apps/management/set_brightness.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from trezor.messages import SetBrightness, Success


async def set_brightness(_msg: SetBrightness) -> Success:
async def set_brightness(msg: SetBrightness) -> Success:
import storage.device as storage_device
from trezor.messages import Success
from trezor.ui.layouts import set_brightness
Expand All @@ -13,5 +13,5 @@ async def set_brightness(_msg: SetBrightness) -> Success:
if not storage_device.is_initialized():
raise NotInitialized("Device is not initialized")

await set_brightness()
await set_brightness(msg.value)
return Success(message="Settings applied")
23 changes: 21 additions & 2 deletions tests/device_tests/test_msg_applysettings.py
Original file line number Diff line number Diff line change
Expand Up @@ -424,13 +424,32 @@ def test_label_too_long(client: Client):


@pytest.mark.models(skip=["legacy", "safe3"])
@pytest.mark.parametrize(
"value",
[
pytest.param(None, id="none_default"),
pytest.param(
-1,
marks=pytest.mark.xfail(),
id="negative_value",
),
pytest.param(0, id="0_min_value"),
pytest.param(128, id="128"),
pytest.param(255, id="255_max_value"),
pytest.param(
256,
marks=pytest.mark.xfail(),
id="256_too_high",
),
],
)
@pytest.mark.setup_client(pin=None)
def test_set_brightness(client: Client):
def test_set_brightness(client: Client, value: int | None):
with client:
assert (
device.set_brightness(
client,
None,
value,
)
== "Settings applied"
)

0 comments on commit 217dd8c

Please sign in to comment.