Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional configurable quirks #82

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

gfcittolin
Copy link

Sorry for not discussing it beforehand, but I had to do some changes to be able to parse some .dbf files I had here, and I thought it could be interesting to contribute the changes back to you.

I've chosen to add a quirks object in the options, so we can selectively enable these quirks (and maybe add others in the future), as I encountered them on the wild. This way, it's fully backwards-compatible with the current version. Unit-tests for them were also written.

Here they are if you find them interesting, but feel free to just ignore them otherwise :)

@coveralls
Copy link

coveralls commented Feb 17, 2020

Pull Request Test Coverage Report for Build 226

  • 21 of 22 (95.45%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 98.851%

Changes Missing Coverage Covered Lines Changed/Added Lines %
index.js 21 22 95.45%
Totals Coverage Status
Change from base Build 219: -0.7%
Covered Lines: 150
Relevant Lines: 151

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants