Allow hiding TUT and RPE UI elements #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treiher
reviewed
Sep 11, 2024
There was a problem hiding this comment.
While hiding all RPE-related elements is fine, hiding all TUT-related fields could lead to unwanted effects in some cases. The "time" field can also be used to track the time of isometric exercises (like Planks), which wouldn't be possible anymore if TUT is set to hidden. This issue should be solvable by introducing exercise types, which is planned for the future (#19). The current implemention is still useful for people that just use repetition-based exercises. Overall, the changes look good to me. I just have a comment about the design.
senier
force-pushed
the
disable_features
branch
from
58068b6
to
46068ed
Compare
treiher
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces settings to hide the UI elements for TUT and RPE. I use neither of those during training and regularly find myself entering the values for reps and load in the wrong fields. The change is only in the UI - the data remains untouched. Settings default to showing those UI elements so that, by default, the UI looks as before.
I ended up using buttons to control the respective settings. I also played around with check boxes, but those don't look great and I had trouble getting them to work in seed. Let me know what you think.
Closes senier#5