Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Get Certificates function #351

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Improve Get Certificates function #351

merged 1 commit into from
Dec 28, 2024

Conversation

Snuffy2
Copy link
Collaborator

@Snuffy2 Snuffy2 commented Dec 28, 2024 •
edited
Loading

  • Prevent running Get Certificates for OPNsense firmware <24.7
  • Change from tzinfo to utcoffset for time checks as was done everywhere else but was missed here (Change from tzinfo to utcoffset #298)

Fixes #350
#346

@Snuffy2 Snuffy2 added the bugfix Fix something that isn't working label Dec 28, 2024
@Snuffy2 Snuffy2 force-pushed the Don't-run-Get-Certificates-if-24.7 branch from 1d87407 to 514de33 Compare December 28, 2024 17:06
@Snuffy2 Snuffy2 mentioned this pull request Dec 28, 2024
Open
@Snuffy2 Snuffy2 changed the title Don't run Get Certificates if <24.7 Improve Get Certificates function Dec 28, 2024
@Snuffy2 Snuffy2 force-pushed the Don't-run-Get-Certificates-if-24.7 branch from 514de33 to 5791d8b Compare December 28, 2024 19:13
@github-actions github-actions bot added the enhancement Enhancing existing functionality label Dec 28, 2024
@Snuffy2 Snuffy2 force-pushed the Don't-run-Get-Certificates-if-24.7 branch from 5791d8b to a885165 Compare December 28, 2024 19:20
@Snuffy2 Snuffy2 removed the enhancement Enhancing existing functionality label Dec 28, 2024
@Snuffy2 Snuffy2 marked this pull request as ready for review December 28, 2024 19:49
@Snuffy2 Snuffy2 merged commit 9f993ac into travisghansen:main Dec 28, 2024
4 checks passed
@Snuffy2 Snuffy2 deleted the Don't-run-Get-Certificates-if-24.7 branch December 28, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix Fix something that isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Error in OPNsenseClient.get_certificates
1 participant
@Snuffy2