Improved implementation of resource's repr method #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous repr value:
>>> project
<<< '<Project: o:kb_org:p:kb1>'
New repr value:
>>> project
<<< Project(id='o:kb_org:p:kb1', attributes={'archived': False, 'datetime_created': '2022-10...1:18:33Z', ...}, relationships={'languages': '...', 'maintainers': '...', ...})
Codecov Report
@@ Coverage Diff @@
## devel #92 +/- ##
==========================================
- Coverage 77.81% 77.40% -0.42%
==========================================
Files 46 46
Lines 3809 3819 +10
==========================================
- Hits 2964 2956 -8
- Misses 845 863 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
besfahbod
reviewed
Dec 10, 2022
Comment on lines
+866
to
+871
| r = reprlib.Repr() | ||
| r.maxlevel = 2 | ||
| r.maxdict = 2 | ||
| r.maxlist = 2 | ||
| r.maxstring = 20 | ||
|
|
There was a problem hiding this comment.
Fwiw, this probably should be a module-level const variable, since it's immutable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous repr value:
New repr value: