Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ansible-lint 6.17.2 #14645

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

juju4
Copy link

@juju4 juju4 commented Aug 26, 2023

Description

fix most ansible-lint (full for server part, client part ongoing)

  • fqcn
  • tasks' names
  • key order
  • move playbooks/* to tasks/* else ansible-lint considers them as playbooks which they are not
  • update .ansible-lint
  • add ansible-galaxy requirements.yml for required collections (+main workflows)

Future work:

  • It seems that gcp_compute_location_info module has been deprecated without any replacement to gather gcp regions.
  • The regexp to validate ansible version does not work if similar matching pattern in requirements.txt aka including ansible-lint.

Motivation and Context

Ensure support with latest ansible and maintainable.

How Has This Been Tested?

Tested in CI and Digital Ocean (default settings or nearly)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@juju4 juju4 requested a review from jackivanov as a code owner August 26, 2023 15:56
@CLAassistant
Copy link

CLAassistant commented Aug 26, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants